Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-run checks if changes are applied #1357

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Re-run checks if changes are applied #1357

wants to merge 4 commits into from

Conversation

brynary
Copy link
Member

@brynary brynary commented Dec 21, 2024

No description provided.

Copy link
Contributor

qltysh bot commented Dec 21, 2024

The code coverage on the diff in this pull request is 75.0%

Drilldown
Path File Coverage Δ
qlty-cli/src/ui/text.rs 1.3
qlty-cli/src/ui/fixes.rs 0.4
qlty-check/src/tool/command_builder.rs -2.6
qlty-check/src/tool/ruby/sys/macos.rs -3.1
qlty-cli/src/commands/check.rs 1.2
qlty-check/src/tool/download.rs -0.7
qlty-check/src/executor/driver.rs 0.9
qlty-check/src/tool/ruby/sys/linux.rs 1.6
qlty-check/src/parser/clippy.rs -0.3

@brynary brynary requested a review from lsegal December 21, 2024 01:45
@brynary
Copy link
Member Author

brynary commented Dec 21, 2024

@lsegal I am seeing a strange test failure on Windows:

---- expected: stdout
++++ actual:   stdout
   1    1 |  ERRORS: 1 
   2    2 | 
   3    3 | exists  Error  Exited with code 0 in [..].[..]s  .qlty/out/invoke-[..].yaml
   4      -         The plugin crashed for some reason
        4 +         "The plugin crashed for some reason"

This is straightforward enough... The output does not match the snapshot, because the actual output is rendering quotes around line 4. However, this does not seem to happen on Mac or Linux, and I am not aware of any behavior which would cause printing output to vary on Windows vs. other platforms.

This is the line where the output is origininating:

tw.write_all(format!("\t{}", style(line).red()).as_bytes())?;

Copy link
Contributor

qltysh bot commented Dec 21, 2024

3 new issues

Tool Category Rule Count
qlty Structure High total complexity (count = 61) 1
qlty Structure Function with high complexity (count = 30): execute 1
qlty Structure Deeply nested control flow (level = 5) 1

qlty successfully analyzed this pull request in 2m.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant