-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn user is using deprecated default source (repository reference instead of default = true
)
#1355
Open
noahd1
wants to merge
15
commits into
main
Choose a base branch
from
nd-source-warning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+72
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brynary
reviewed
Dec 20, 2024
brynary
reviewed
Dec 21, 2024
Co-authored-by: Bryan Helmkamp <[email protected]>
Fairly dumb refactoring, just splitting a big file down into more smaller files with clearer inputs
On Windows, the output string is quoted. On Mac and Linux, it is not. This snapshot hopefully works for both.
Addresssed comments / merged in main to get tests passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently changed the default source for newly generated
qlty.toml
files from:to:
This was so that the plugins referenced, by default, are guaranteed to be compatible with the binary used, because the plugins are compiled into the binary.
This works for newly generated qlty.toml files, but old generated ones in the wild should, ideally, be updated. They will continue to work as is, and a repository source is still a valid way to load sources, however, it is inherently more susceptible to incompatability issues than
default = true
.This PR adds a warning if using the old-style default source.
Warning looks like this currently: