fix default qubit warning for simulator #202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splch
changed the title
gmauricio
approved these changes
Oct 22, 2024
Cynocracy
approved these changes
Oct 22, 2024
qiskit_ionq/helpers.py
Outdated
|
|
||
| Returns: | ||
| int: The number of qubits for the backend. | ||
| """ | ||
| # Handle known case for the simulator directly | ||
| if backend == "simulator": |
There was a problem hiding this comment.
this feels a little weird in get_n_qubits, is this because this is externally usable?
There was a problem hiding this comment.
i just updated it to use our publicly accessible backends endpoint which provides qubit counts :D
basnijholt
reviewed
Nov 12, 2024
| @@ -515,17 +517,19 @@ def resolve_credentials(token: str | None = None, url: str | None = None): | |||
| Returns: | |||
| dict[str]: A dict with "token" and "url" keys, for use by a client. | |||
| """ | |||
| # Cache dotenv and environment variable lookups | |||
| env_values = dotenv_values() | |||
There was a problem hiding this comment.
This will mean that if one calls resolve_credentials and doesn't have the env vars set, then sets it, then calls resolve_credentials again, which will return the incorrect thing.
No need to cache such a cheap operation IMHO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the simulator doesn't have accessible qubit defaults, so we need to manually add this
Details and comments
prevents a warning from the backend initialization