Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct MS gate matrix #174

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Correct MS gate matrix #174

merged 2 commits into from
Mar 28, 2024

Conversation

speller26
Copy link
Contributor

@speller26 speller26 commented Mar 5, 2024

Summary

Fixes #162 ; current matrix is big-endian, while Qiskit is little-endian.

Details and comments

@speller26 speller26 changed the title Correct MS gate Correct MS gate matrix Mar 5, 2024
Copy link
Collaborator

@splch splch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! thanks for the catch

@splch splch merged commit 226d0d3 into qiskit-community:main Mar 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MS gate matrix is wrong
2 participants