Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getattr self.ql.loader default value #1427

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Fix getattr self.ql.loader default value #1427

merged 1 commit into from
Jan 14, 2024

Conversation

dotCirill
Copy link

#1416 fix

elicn
elicn approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@elicn elicn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this implementation does not support 0 as a valid entry point, since both 0 and None are considered as False. We could change that to query is not None explicitly, but maybe that is good enough.

@elicn elicn requested a review from ucgJhe January 13, 2024 18:33
@xwings xwings merged commit c6de544 into qilingframework:dev Jan 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elicn elicn elicn approved these changes

@xwings xwings xwings approved these changes

@ucgJhe ucgJhe Awaiting requested review from ucgJhe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dotCirill @xwings @elicn