Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dbi #1542

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Remove dbi #1542

merged 2 commits into from
Dec 18, 2024

Conversation

Edoardo-Pedicillo
Copy link
Contributor

Closes #1523

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (4588671) to head (b6461bd).
Report is 52 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1542      +/-   ##
==========================================
- Coverage   99.68%   99.67%   -0.02%     
==========================================
  Files          80       76       -4     
  Lines       11607    11229     -378     
==========================================
- Hits        11571    11193     -378     
  Misses         36       36              
Flag Coverage Δ
unittests 99.67% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Edoardo-Pedicillo Edoardo-Pedicillo marked this pull request as ready for review December 16, 2024 08:26
Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
I think the DBI has still to be removed from qibo/doc/source/code-examples/tutorials.

Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Edoardo-Pedicillo Edoardo-Pedicillo added this pull request to the merge queue Dec 18, 2024
Merged via the queue into master with commit 901b162 Dec 18, 2024
27 checks passed
@Edoardo-Pedicillo Edoardo-Pedicillo deleted the remove_dbi branch December 18, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move qibo.models.dbi to qiboteam/dbqa repostitory and create a pip package dependancy
3 participants