-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Documentation for wire_names
and _Global
#1531
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1531 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 80 80
Lines 11585 11586 +1
=======================================
+ Hits 11549 11550 +1
Misses 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, the PR seems alright, and I just have a relevant note about a single point.
However, if I'm correct, this is still partially lacking the explanation for a question that we already received, i.e. the role of wire_names
in the qubit selection.
With this, I mean that we should clarify the following points:
wire_names
is absolutely not limiting the qubits used for placing or routing, if these non-trivial passes are included in the transpiler - thus, usingwire_names
as input for a non-trivial placer/routing is only possibly helpful to improve the transpiler solution, but it won't prevent the usage of any qubit in the platformwire_names
are instead exactly honored by the Qibolab backend, when used directly (no transpilation), leading to compilation errors if the connectivity is insufficient- padding should not be required at any stage, since the information that used to provide is now fully replaced by the usage of
wire_names
and theconnectivity
, to the point that we should even be able to drop thePreprocessing
(though this should be confirmed)
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Renato Mello <[email protected]>
Co-authored-by: Renato Mello <[email protected]>
Co-authored-by: Renato Mello <[email protected]>
Co-authored-by: Renato Mello <[email protected]>
Co-authored-by: Renato Mello <[email protected]>
Co-authored-by: Renato Mello <[email protected]>
Co-authored-by: Renato Mello <[email protected]>
Co-authored-by: Renato Mello <[email protected]>
Co-authored-by: Renato Mello <[email protected]>
Co-authored-by: Renato Mello <[email protected]>
Co-authored-by: Renato Mello <[email protected]>
Co-authored-by: Renato Mello <[email protected]>
Co-authored-by: Renato Mello <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Renato Mello <[email protected]>
Co-authored-by: Renato Mello <[email protected]>
for more information, see https://pre-commit.ci
All changes are related to variable names, docstrings, and documentation. No changes to the logic.
Checklist: