-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update outdated docstrings #1512
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1512 +/- ##
==========================================
- Coverage 99.72% 99.72% -0.01%
==========================================
Files 80 80
Lines 11784 11783 -1
==========================================
- Hits 11752 11751 -1
Misses 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some minor suggestions follow.
Co-authored-by: Matteo Robbiati <[email protected]>
Co-authored-by: Matteo Robbiati <[email protected]>
Co-authored-by: Matteo Robbiati <[email protected]>
Co-authored-by: Matteo Robbiati <[email protected]>
Co-authored-by: Matteo Robbiati <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
A lot of the older docstrings do not match the new functionalities added on$2$ or so years. This PR updates them.
qibo
in the lastOne of the main goals is to discourage people who first interact with the docs from getting in the habit of using unnecessarily short variable names, which leads to issues when the same people then start contributing code in PRs.
Checklist: