Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to_stinespring to quantum_info.superoperator_transformations #1492

Merged
merged 11 commits into from
Oct 28, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Oct 16, 2024

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request quantum_info module PRs and issues related to the quantum information module labels Oct 16, 2024
@renatomello renatomello added this to the Qibo 0.2.13 milestone Oct 16, 2024
@renatomello renatomello self-assigned this Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (473bcf7) to head (475279b).
Report is 71 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1492   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files          81       81           
  Lines       11935    11942    +7     
=======================================
+ Hits        11926    11933    +7     
  Misses          9        9           
Flag Coverage Δ
unittests 99.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello marked this pull request as ready for review October 16, 2024 11:50
@MatteoRobbiati MatteoRobbiati self-requested a review October 23, 2024 09:19
@scarrazza
Copy link
Member

Do you prefer to merge this now or wait for the next release?

@renatomello
Copy link
Contributor Author

Do you prefer to merge this now or wait for the next release?

Ideally now.

Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Some minor comments follow.

@scarrazza
Copy link
Member

@renatomello are you planning further changes or are you done?

@scarrazza scarrazza merged commit 0b97e33 into master Oct 28, 2024
27 checks passed
@renatomello renatomello deleted the to_stinespring branch October 29, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request quantum_info module PRs and issues related to the quantum information module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants