Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid logging for missing backends #1486

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

alecandido
Copy link
Member

@alecandido alecandido commented Oct 11, 2024

As they may also be part of a backend search loop.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

As they may also be part of a backend search loop
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (9863ca1) to head (95c71fa).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1486   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          81       81           
  Lines       11792    11792           
=======================================
  Hits        11784    11784           
  Misses          8        8           
Flag Coverage Δ
unittests 99.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@scarrazza scarrazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works perfectly.

@alecandido alecandido added this pull request to the merge queue Oct 14, 2024
Merged via the queue into master with commit 2dc31e6 Oct 14, 2024
28 checks passed
@renatomello renatomello deleted the silence-missing-backend branch October 17, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants