Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping controlled try/except for M gate in from_dict #1483

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

BrunoLiegiBastonLiegi
Copy link
Contributor

This avoids the try/except for controlled gates in from_dict when the gate is a measurement. Should close #1482.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (36ed3fe) to head (9b5776c).
Report is 53 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1483   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          81       81           
  Lines       11820    11822    +2     
=======================================
+ Hits        11812    11814    +2     
  Misses          8        8           
Flag Coverage Δ
unittests 99.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi marked this pull request as ready for review October 10, 2024 10:13
@scarrazza scarrazza merged commit 9863ca1 into master Oct 11, 2024
28 checks passed
@renatomello renatomello deleted the controlled_M_bug branch October 17, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Measurement gates cannot be controlled
2 participants