-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating TensorFlowBackend to Qiboml #1479
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1479 +/- ##
==========================================
- Coverage 99.92% 99.74% -0.18%
==========================================
Files 81 80 -1
Lines 11935 11761 -174
==========================================
- Hits 11926 11731 -195
- Misses 9 30 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@MatteoRobbiati anything else for this PR, can we merge? |
This is ready but docs have to be updated still. I would prefer complete this task and then merge, so that docs will be updated with the code. |
Note that this should be run during Tensorflow initialization in the beginning | ||
of the script and before creating the qibo backend. | ||
For similar wariness when using a machine learning backend (such as TensorFlow or Pytorch) | ||
please refer to the Qiboml documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A link here would be probably helpful, even though I don't think we have any right now in qiboml. This is more a reminder to add it, once we have it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can add a simple documentation in Qiboml for now, just with these instructions.
Can we fix tests and merge? |
Checklist: