Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating TensorFlowBackend to Qiboml #1479

Merged
merged 51 commits into from
Oct 28, 2024
Merged

Migrating TensorFlowBackend to Qiboml #1479

merged 51 commits into from
Oct 28, 2024

Conversation

MatteoRobbiati
Copy link
Contributor

@MatteoRobbiati MatteoRobbiati commented Oct 8, 2024

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@MatteoRobbiati MatteoRobbiati marked this pull request as draft October 8, 2024 16:55
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (473bcf7) to head (65a20a2).
Report is 71 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1479      +/-   ##
==========================================
- Coverage   99.92%   99.74%   -0.18%     
==========================================
  Files          81       80       -1     
  Lines       11935    11761     -174     
==========================================
- Hits        11926    11731     -195     
- Misses          9       30      +21     
Flag Coverage Δ
unittests 99.74% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatteoRobbiati MatteoRobbiati marked this pull request as ready for review October 15, 2024 15:39
pyproject.toml Outdated Show resolved Hide resolved
src/qibo/backends/__init__.py Outdated Show resolved Hide resolved
src/qibo/backends/__init__.py Show resolved Hide resolved
src/qibo/models/error_mitigation.py Show resolved Hide resolved
@scarrazza
Copy link
Member

@MatteoRobbiati anything else for this PR, can we merge?

@MatteoRobbiati
Copy link
Contributor Author

This is ready but docs have to be updated still. I would prefer complete this task and then merge, so that docs will be updated with the code.

Note that this should be run during Tensorflow initialization in the beginning
of the script and before creating the qibo backend.
For similar wariness when using a machine learning backend (such as TensorFlow or Pytorch)
please refer to the Qiboml documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A link here would be probably helpful, even though I don't think we have any right now in qiboml. This is more a reminder to add it, once we have it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can add a simple documentation in Qiboml for now, just with these instructions.

@scarrazza
Copy link
Member

Can we fix tests and merge?

@scarrazza scarrazza enabled auto-merge October 28, 2024 18:10
@scarrazza scarrazza added this pull request to the merge queue Oct 28, 2024
Merged via the queue into master with commit 099d7a0 Oct 28, 2024
27 checks passed
@renatomello renatomello deleted the tf_migration branch October 29, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qiboml refactor Code is working but could be simplified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants