Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add negativity to quantum_info.entanglement #1456

Merged
merged 26 commits into from
Oct 8, 2024
Merged

Add negativity to quantum_info.entanglement #1456

merged 26 commits into from
Oct 8, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Sep 19, 2024

This needs to be merged after #1454

EDIT: Also needs #1462

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request quantum_info module PRs and issues related to the quantum information module labels Sep 19, 2024
@renatomello renatomello added this to the Qibo 0.2.13 milestone Sep 19, 2024
@renatomello renatomello self-assigned this Sep 19, 2024
@renatomello renatomello marked this pull request as draft September 19, 2024 09:26
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (9fb5161) to head (f5da5d8).
Report is 19 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1456   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          81       81           
  Lines       11750    11783   +33     
=======================================
+ Hits        11742    11775   +33     
  Misses          8        8           
Flag Coverage Δ
unittests 99.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello changed the base branch from master to partial_transpose September 23, 2024 10:41
@renatomello renatomello marked this pull request as ready for review September 23, 2024 10:54
@renatomello
Copy link
Contributor Author

@AlejandroSopena @BrunoLiegiBastonLiegi @stavros11 this is ready but pointing to the partial_transpose branch in PR #1462. That PR needs to be merged before this one.

@renatomello renatomello marked this pull request as draft October 7, 2024 05:12
@renatomello renatomello marked this pull request as ready for review October 7, 2024 12:56
@renatomello renatomello changed the base branch from partial_transpose to master October 7, 2024 12:56
@renatomello renatomello enabled auto-merge October 8, 2024 10:54
@renatomello renatomello added this pull request to the merge queue Oct 8, 2024
Merged via the queue into master with commit b53ce52 Oct 8, 2024
24 of 25 checks passed
@renatomello renatomello deleted the negativity branch October 8, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request quantum_info module PRs and issues related to the quantum information module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants