-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing hermitian
argument to backend.calculate_eigenvalues
and backend.calculate_eigenvectors
methods
#1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatomello
added
bug
Something isn't working
quantum_info module
PRs and issues related to the quantum information module
labels
Sep 16, 2024
alecandido
reviewed
Sep 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1448 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 81 81
Lines 11708 11708
=======================================
Hits 11701 11701
Misses 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
renatomello
changed the title
Add
Add missing Sep 18, 2024
hermitian
argument to missing backend.calculate_eigenvalues
and backend.calculate_eigenvectors
methodshermitian
argument to backend.calculate_eigenvalues
and backend.calculate_eigenvectors
methods
BrunoLiegiBastonLiegi
approved these changes
Sep 18, 2024
AlejandroSopena
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
quantum_info module
PRs and issues related to the quantum information module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1447 together with qiboteam/qibojit#188. Tests should be run locally to verify that they are passing on GPUs.
The
numpy
,numba
,pytorch
, andtensorflow
backends already had this argument in their methods, butabstract
,cupy
, andcuquantum
did not. This fixes the issue.Checklist: