Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing hermitian argument to backend.calculate_eigenvalues and backend.calculate_eigenvectors methods #1448

Merged
merged 8 commits into from
Sep 20, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Sep 16, 2024

Closes #1447 together with qiboteam/qibojit#188. Tests should be run locally to verify that they are passing on GPUs.

The numpy, numba, pytorch, and tensorflow backends already had this argument in their methods, but abstract, cupy, and cuquantum did not. This fixes the issue.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello self-assigned this Sep 16, 2024
@renatomello renatomello added bug Something isn't working quantum_info module PRs and issues related to the quantum information module labels Sep 16, 2024
@renatomello renatomello added this to the Qibo 0.2.12 milestone Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (df709ce) to head (efb3f6a).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1448   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          81       81           
  Lines       11708    11708           
=======================================
  Hits        11701    11701           
  Misses          7        7           
Flag Coverage Δ
unittests 99.94% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello changed the title Add hermitian argument to missing backend.calculate_eigenvalues and backend.calculate_eigenvectors methods Add missing hermitian argument to backend.calculate_eigenvalues and backend.calculate_eigenvectors methods Sep 18, 2024
@renatomello renatomello added this pull request to the merge queue Sep 20, 2024
Merged via the queue into master with commit 647e462 Sep 20, 2024
27 checks passed
@renatomello renatomello deleted the hermitian branch September 20, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quantum_info module PRs and issues related to the quantum information module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failing with cupy
4 participants