Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Gate.matrix and Circuit.unitary in the presence of Gate.controlled_by method #1367

Merged
merged 21 commits into from
Jun 27, 2024
Merged

Fix Gate.matrix and Circuit.unitary in the presence of Gate.controlled_by method #1367

merged 21 commits into from
Jun 27, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Jun 20, 2024 •
edited
Loading

This closes #1279 and #1354

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added the bug Something isn't working label Jun 20, 2024
@renatomello renatomello added this to the Qibo 0.2.9 milestone Jun 20, 2024
@renatomello renatomello self-assigned this Jun 20, 2024
@renatomello renatomello linked an issue Jun 21, 2024 that may be closed by this pull request
Inconsistencies on gate definitions coming from Gate.controlled_by and Circuit.gates_of_type #1354
Closed
@renatomello renatomello mentioned this pull request Jun 24, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Jun 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (c68e58b) to head (3637416).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1367      +/-   ##
==========================================
- Coverage   99.84%   99.84%   -0.01%     
==========================================
  Files          74       74              
  Lines       10791    10781      -10     
==========================================
- Hits        10774    10764      -10     
  Misses         17       17
Flag Coverage Δ
unittests 99.84% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello requested review from BrunoLiegiBastonLiegi and removed request for andrea-pasquale June 24, 2024 06:20
@stavros11 stavros11 mentioned this pull request Jun 24, 2024
Open
stavros11
stavros11 reviewed Jun 24, 2024
View reviewed changes
src/qibo/gates/abstract.py Outdated Show resolved Hide resolved
src/qibo/backends/numpy.py Show resolved Hide resolved
tests/test_gates_gates.py Show resolved Hide resolved
@renatomello @stavros11
Update src/qibo/gates/abstract.py
b7a8212 
Co-authored-by: Stavros Efthymiou <[email protected]>
stavros11
stavros11 approved these changes Jun 24, 2024
View reviewed changes
tests/test_gates_gates.py Show resolved Hide resolved
@scarrazza scarrazza self-requested a review June 27, 2024 15:56
scarrazza
scarrazza approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@scarrazza scarrazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @renatomello.

@scarrazza scarrazza added this pull request to the merge queue Jun 27, 2024
Merged via the queue into master with commit 8fc5a6e Jun 27, 2024
27 checks passed
@renatomello renatomello deleted the controlled_by branch June 27, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavros11 stavros11 stavros11 approved these changes

@scarrazza scarrazza scarrazza approved these changes

@alecandido alecandido Awaiting requested review from alecandido

@MatteoRobbiati MatteoRobbiati Awaiting requested review from MatteoRobbiati

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi Awaiting requested review from BrunoLiegiBastonLiegi

Assignees

@renatomello renatomello

Labels
bug Something isn't working
Projects
None yet
Milestone
Qibo 0.2.9
3 participants
@renatomello @scarrazza @stavros11