Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when initial state shape is wrong #1361

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Conversation

stavros11
Copy link
Member

@stavros11 stavros11 commented Jun 13, 2024

Implements the fix described in #646 (comment) and closes #646.

Note that without this, the qibojit-numba backend will proceed with execution and return wrong results, sometimes with a non-normalized final state or segmentation fault.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (70901d5) to head (28da693).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1361   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          74       74           
  Lines       10760    10763    +3     
=======================================
+ Hits        10743    10746    +3     
  Misses         17       17           
Flag Coverage Δ
unittests 99.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello added the enhancement New feature or request label Jun 19, 2024
@scarrazza scarrazza self-requested a review June 25, 2024 09:19
Copy link
Member

@scarrazza scarrazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stavros11.

@scarrazza scarrazza added this pull request to the merge queue Jun 25, 2024
Merged via the queue into master with commit 4b01f25 Jun 25, 2024
27 checks passed
@stavros11 stavros11 deleted the initialshape branch June 25, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpredictable behaviour when setting initial state for circuit.light_cone()
4 participants