Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qibolab backend #1262

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Fix qibolab backend #1262

merged 1 commit into from
Mar 13, 2024

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Mar 13, 2024

Closes #1261.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@andrea-pasquale andrea-pasquale added the bug Something isn't working label Mar 13, 2024
@andrea-pasquale andrea-pasquale self-assigned this Mar 13, 2024
@andrea-pasquale
Copy link
Contributor Author

We may want to consider to make a release of qibo pretty soon to fix this issue given that both qibolab and qibocal use the latest release of qibo.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (a603ddd) to head (fafc75f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1262   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files          72       72           
  Lines       10454    10454           
=======================================
  Hits        10449    10449           
  Misses          5        5           
Flag Coverage Δ
unittests 99.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrea-pasquale
Copy link
Contributor Author

We may want to consider to make a release of qibo pretty soon to fix this issue given that both qibolab and qibocal use the latest release of qibo.

Thoughts @alecandido @scarrazza?

@andrea-pasquale andrea-pasquale added this to the Qibo 0.2.6 milestone Mar 13, 2024
@scarrazza scarrazza merged commit 5075232 into master Mar 13, 2024
23 checks passed
@stavros11 stavros11 deleted the fix_qibolab branch March 13, 2024 19:50
@alecandido
Copy link
Member

Sorry @andrea-pasquale, it happened during #1243, I didn't check carefully enough...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting qibolab backend
5 participants