-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate CliffordBackend
and stim
#1248
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1248 +/- ##
===========================================
- Coverage 100.00% 99.95% -0.05%
===========================================
Files 72 72
Lines 10440 10452 +12
===========================================
+ Hits 10440 10447 +7
- Misses 0 5 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stim
CliffordBackend
and stim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be alright, just a few comments to polish and improve readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @renatomello looks good. There is just one thing that is missing in my opinion, which is in the Clifford
object let stim
take care of the samples generation.
There is a way to do it, but it's not as direct as the circuit execution, so maybe it'd be better to do it in a separate PR. |
Checklist: