Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate CliffordBackend and stim #1248

Merged
merged 12 commits into from
Mar 6, 2024
Merged

Integrate CliffordBackend and stim #1248

merged 12 commits into from
Mar 6, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Mar 5, 2024

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file quantum_info module PRs and issues related to the quantum information module labels Mar 5, 2024
@renatomello renatomello added this to the Qibo 0.2.6 milestone Mar 5, 2024
@renatomello renatomello self-assigned this Mar 5, 2024
@renatomello renatomello linked an issue Mar 5, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (d559a61) to head (07291f5).

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #1248      +/-   ##
===========================================
- Coverage   100.00%   99.95%   -0.05%     
===========================================
  Files           72       72              
  Lines        10440    10452      +12     
===========================================
+ Hits         10440    10447       +7     
- Misses           0        5       +5     
Flag Coverage Δ
unittests 99.95% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello changed the title Integrate Clifford backend and stim Integrate CliffordBackend and stim Mar 5, 2024
@renatomello renatomello requested a review from alecandido March 5, 2024 12:00
Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be alright, just a few comments to polish and improve readability.

src/qibo/backends/clifford.py Outdated Show resolved Hide resolved
src/qibo/backends/clifford.py Outdated Show resolved Hide resolved
src/qibo/backends/clifford.py Outdated Show resolved Hide resolved
Copy link
Contributor

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @renatomello looks good. There is just one thing that is missing in my opinion, which is in the Clifford object let stim take care of the samples generation.

src/qibo/backends/clifford.py Show resolved Hide resolved
tests/test_backends_clifford.py Show resolved Hide resolved
@renatomello
Copy link
Contributor Author

Thanks @renatomello looks good. There is just one thing that is missing in my opinion, which is in the Clifford object let stim take care of the samples generation.

There is a way to do it, but it's not as direct as the circuit execution, so maybe it'd be better to do it in a separate PR.

@renatomello renatomello added this pull request to the merge queue Mar 6, 2024
Merged via the queue into master with commit 62c4dfd Mar 6, 2024
21 checks passed
@renatomello renatomello deleted the stim branch March 6, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation quantum_info module PRs and issues related to the quantum information module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add stim as an engine to the Clifford backend
3 participants