Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin download): add application/x-zip-compressed for header Accept #587

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

jmkerloch
Copy link
Collaborator

Some server might not consider plugin .zip as application/zip but application/x-zip-compressed.

In this case, the server doesn't return the plugin .zip but an error page.

In this PR we add application/x-zip-compressed to the header Accept to fix this issue.

@jmkerloch jmkerloch self-assigned this Nov 29, 2024
@jmkerloch jmkerloch added the enhancement New feature or request label Nov 29, 2024
@jmkerloch jmkerloch requested a review from Guts November 29, 2024 08:58
@github-actions github-actions bot added the jobs Scenarios and jobs label Nov 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.35%. Comparing base (3c2c7ca) to head (49fbc32).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #587   +/-   ##
=======================================
  Coverage   70.35%   70.35%           
=======================================
  Files          47       47           
  Lines        3188     3188           
  Branches      558      558           
=======================================
  Hits         2243     2243           
  Misses        747      747           
  Partials      198      198           
Flag Coverage Δ
unittests 69.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...deployment_toolbelt/jobs/job_plugins_downloader.py 50.37% <ø> (ø)

@jmkerloch jmkerloch requested a review from Guts November 29, 2024 11:34
Copy link

sonarcloud bot commented Nov 29, 2024

@jmkerloch jmkerloch merged commit d1a9522 into main Nov 29, 2024
25 checks passed
@jmkerloch jmkerloch deleted the feat/additionnal_zip_content_type branch November 29, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jobs Scenarios and jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants