Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pvf priority #2305

Merged
merged 5 commits into from
Dec 16, 2024
Merged

pvf priority #2305

merged 5 commits into from
Dec 16, 2024

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Dec 4, 2024

Referenced issues

Description of the Change

  • metric for pvf queue size
  • split pvf queue by job kind
  • process queued approval jobs before queued backing jobs

Possible Drawbacks

  • gives all time to approval jobs (rust gives 94% to approval and 6% to backing)

@turuslan
pvf priority
50fbd01 
Signed-off-by: turuslan <[email protected]>
@turuslan
metric queue size
ba3c325 
Signed-off-by: turuslan <[email protected]>
@turuslan turuslan requested review from kamilsa and ErakhtinB December 4, 2024 17:17
@turuslan
log
5eeb439 
Signed-off-by: turuslan <[email protected]>
ErakhtinB
ErakhtinB approved these changes Dec 5, 2024
View reviewed changes
core/parachain/pvf/workers.cpp Show resolved Hide resolved
@turuslan turuslan enabled auto-merge (squash) December 16, 2024 02:37
@turuslan turuslan merged commit d056f23 into master Dec 16, 2024
11 of 13 checks passed
@turuslan turuslan deleted the feature/pvf-priority branch December 16, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErakhtinB ErakhtinB ErakhtinB approved these changes

@kamilsa kamilsa kamilsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @kamilsa @ErakhtinB