Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move from div to button and code smells fix #1294

Merged
merged 23 commits into from
Dec 8, 2023
Merged

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Dec 2, 2023

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (504956d) 94.67% compared to head (076a8b9) 94.73%.
Report is 14 commits behind head on master.

Files Patch % Lines
...on-rotate-image-90/menu-option-rotate-image-90.tsx 85.71% 4 Missing and 2 partials ⚠️
...ts/organisms/detail-view-media/detail-view-mp4.tsx 0.00% 1 Missing and 1 partial ⚠️
...components/organisms/menu-archive/menu-archive.tsx 87.50% 1 Missing ⚠️
...ts/organisms/menu-detail-view/menu-detail-view.tsx 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1294      +/-   ##
==========================================
+ Coverage   94.67%   94.73%   +0.06%     
==========================================
  Files         573      575       +2     
  Lines       20285    20284       -1     
  Branches     3169     3164       -5     
==========================================
+ Hits        19204    19217      +13     
+ Misses        713      699      -14     
  Partials      368      368              
Flag Coverage Δ
all 94.73% <89.69%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qdraw qdraw changed the title code smells move from div to button and code smells fix Dec 7, 2023
Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.9% 90.9% Coverage
0.0% 0.0% Duplication

@qdraw qdraw merged commit 87f7bb0 into master Dec 8, 2023
17 checks passed
@qdraw qdraw deleted the feature/202312_code_smells branch December 8, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant