Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code smells and add tests #1278

Merged
merged 17 commits into from
Nov 10, 2023
Merged

Fix code smells and add tests #1278

merged 17 commits into from
Nov 10, 2023

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Nov 9, 2023

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (74f2de6) 94.60% compared to head (82ffc3d) 94.68%.

❗ Current head 82ffc3d differs from pull request most recent head 666c272. Consider uploading reports for the commit 666c272 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1278      +/-   ##
==========================================
+ Coverage   94.60%   94.68%   +0.07%     
==========================================
  Files         572      573       +1     
  Lines       20244    20285      +41     
  Branches     3187     3169      -18     
==========================================
+ Hits        19152    19206      +54     
+ Misses        723      711      -12     
+ Partials      369      368       -1     
Flag Coverage Δ
all 94.68% <94.85%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...foundation.readmeta/ReadMetaHelpers/ReadMetaXmp.cs 97.38% <100.00%> (+0.26%) ⬆️
...mbnailmeta/Services/OffsetDataMetaExifThumbnail.cs 100.00% <100.00%> (ø)
...components/organisms/menu-archive/menu-archive.tsx 92.04% <100.00%> (+2.35%) ⬆️
...organisms/menu-archive/shared/upload-menu-item.tsx 100.00% <100.00%> (ø)
...ure.health/UpdateCheck/Services/CheckForUpdates.cs 94.28% <0.00%> (ø)
.../starsky.feature.metaupdate/Services/DeleteItem.cs 98.57% <96.55%> (-1.43%) ⬇️
...ndation.database/Helpers/FileIndexCompareHelper.cs 89.23% <75.00%> (-0.62%) ⬇️
...ebar/archive-sidebar-label-edit-search-replace.tsx 92.77% <90.47%> (+0.17%) ⬆️
...oundation.readmeta/ReadMetaHelpers/ReadMetaExif.cs 94.36% <95.52%> (+3.03%) ⬆️
...ation.platform/Helpers/AppSettingsCompareHelper.cs 92.24% <92.24%> (+0.65%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qdraw qdraw changed the title small refactorings Fix code smells and add tests Nov 10, 2023
@qdraw qdraw merged commit e90d332 into master Nov 10, 2023
12 checks passed
@qdraw qdraw deleted the feature/202311_code_smells_9 branch November 10, 2023 09:26
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.8% 96.8% Coverage
0.1% 0.1% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant