-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of room owners and banning functionality #321
Conversation
With new commits a VK button is added next to each player's name, similar to ban button. When pressing VK a 90 second cooldown activates for that user to init a VK. the VK init is announced to players, along with the total threshold. If a different player then presses the VK button for that person who the VK was initiated on, they will have voted (also cooldown). Once enough votes have occurred to meet the threshold the user is banned and cannot rejoin the room.
I'm sure there's some loophole here I'm missing, lol. |
Finished all changes. Ready for final review/PR approval |
PR looks good, but I would like to test it across multiple clients and also add a description of votekicks somewhere on the page |
That is a good idea, I do not know how this would perform on other platforms although it should work regardless. For the votekicks, I think adding a paragraph on the about page would be best. Can't think of anywhere else to put it. Edit: added the about page changes |
This is the PR for the room owners/banning mechanisms. Feel free to look over the changes and ask me any questions, organize it the way you prefer, or just change around the code. Linted with semistandard.
Additions:
Future goals: