Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of room owners and banning functionality #321

Merged
merged 16 commits into from
Nov 12, 2024

Conversation

1337isnot1337
Copy link
Contributor

@1337isnot1337 1337isnot1337 commented Nov 5, 2024

This is the PR for the room owners/banning mechanisms. Feel free to look over the changes and ask me any questions, organize it the way you prefer, or just change around the code. Linted with semistandard.

Additions:

  • Creator of a room is given Owner metadata
  • Creator has a crown emoji next to their name to set them apart
  • Creator sees a ban button next to each name, pressing it will permaban said player from that room in particular
  • This does not apply for the default rooms

Future goals:

  • Only have creators in private rooms
  • Add a votekick feature to public rooms and the default rooms where a majority of players can remove another
  • Smooth out the code
  • Add a way to mute someone's chat

@1337isnot1337
Copy link
Contributor Author

With new commits a VK button is added next to each player's name, similar to ban button. When pressing VK a 90 second cooldown activates for that user to init a VK. the VK init is announced to players, along with the total threshold. If a different player then presses the VK button for that person who the VK was initiated on, they will have voted (also cooldown). Once enough votes have occurred to meet the threshold the user is banned and cannot rejoin the room.

  • In private rooms, the owner cannot be votekicked
  • In public rooms, the owner is not marked and can not ban, but if room is switched to private then owner is marked + can ban

I'm sure there's some loophole here I'm missing, lol.

@1337isnot1337
Copy link
Contributor Author

Finished all changes. Ready for final review/PR approval

@geoffrey-wu
Copy link
Member

PR looks good, but I would like to test it across multiple clients and also add a description of votekicks somewhere on the page

@1337isnot1337
Copy link
Contributor Author

1337isnot1337 commented Nov 9, 2024

PR looks good, but I would like to test it across multiple clients and also add a description of votekicks somewhere on the page

That is a good idea, I do not know how this would perform on other platforms although it should work regardless. For the votekicks, I think adding a paragraph on the about page would be best. Can't think of anywhere else to put it.

Edit: added the about page changes

@geoffrey-wu geoffrey-wu merged commit 18279eb into qbreader:main Nov 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants