Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add published date to PirateBay results #277

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

ducalex
Copy link
Contributor

@ducalex ducalex commented Apr 29, 2024

This PR adds the date field to the results from the piratebay.py plugin.

It is meant to go with the recently merged PR: qbittorrent/qBittorrent#20703

The change does not break compatibility with older (current) qBittorrent versions.

image

@xavier2k6
Copy link
Member

xavier2k6 commented Jun 27, 2024

@ducalex same thing that came up from that PR in main repo, should commit be Added published date column? , also versions.txt needs to be bumped.

Please also include a screenshot in o.p.

@ducalex ducalex force-pushed the ducalex/add-date-field-tpb branch from bb12db7 to 4cd8699 Compare June 28, 2024 20:30
@ducalex ducalex force-pushed the ducalex/add-date-field-tpb branch from 4cd8699 to 70fe649 Compare June 28, 2024 20:34
@ducalex
Copy link
Contributor Author

ducalex commented Jun 28, 2024

I've addressed the issues you mentioned!

When my date PR was merged it was indeed Published Date but I don't know if it will change by the time it gets to a release (I think it was quickly merged by maintainers to avoid bikeshedding on the name). So feel free to re-title my commit before merging as you see fit.

@xavier2k6 xavier2k6 changed the title Add date to PirateBay results Add published date to PirateBay results Jun 30, 2024
@xavier2k6 xavier2k6 merged commit 6c7f044 into qbittorrent:master Jun 30, 2024
6 checks passed
@xavier2k6
Copy link
Member

@ducalex Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants