Force tankHealth & oilLevel to be float values to fix leaking issue #1149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are getting a lot of reports of issues with fuel leaking especially; this seems to be due to
SetVehicleProperties
not forcing these values to be a float. Some scripts may write to the vehicle props JSON directly and set the float fuelTankHealth to an integer value of 1000, and people are incorrectly blaming QBCore for this.These changes will safeguard players from this potential issue.
You can replicate this easily yourself by running the following - your car will instantly start leaking fuel. This doesn't happen when running the same code with the value
1000.0
instead of1000
.Checklist