Support partial usbtmc reads and request the size
amount of bytes from the device
#470
+50
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another update for reading the data back from the device. this enhances the PR #465
changes explained below:
req = BulkInMessage.build_array(self._btag, size, None)
we want to request the amount of bytes from the device which user specifies. therefore the header may specify more bytes then in a single transactionwMaxPacketSize
can be transmitted. the device may response with less bytes.resp = raw_read(self.usb_recv_ep.wMaxPacketSize)
you may requestwMaxPacketSize
but the device may send less bytes than requestedfix the indentation of the
received_message.extend(received_transfer[: response.transfer_size])
this should always remove the alignment bytes instead of only onEOM
updated the code to request
x
amount ofwMaxPacketSize
to be read instead ofwMaxPacketSize
this to improve readout speeds.Closes # (insert issue number if relevant)
Executed
black . && isort -c . && flake8
with no errorsThe change is fully covered by automated unit tests
Documented in docs/ as appropriate
Added an entry to the CHANGES file