Move import to be dask-dist friendly #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make trollflow2 more multiprocessing / dask-distributed friendly. Move the launcher import in satpy_launcher.py within the main function, so that it only gets executed in the primary process. The call to `Manager()` in `trollflow2.__init__.py` was causing attempts to use trollflow2 with dask distributed to fail with a RuntimeError.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 95.78% 95.78%
=======================================
Files 12 12
Lines 2989 2989
=======================================
Hits 2863 2863
Misses 126 126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make trollflow2 more multiprocessing / dask-distributed friendly. Move the launcher import in satpy_launcher.py within the main function, so that it only gets executed in the primary process. The call to
Manager()introllflow2.__init__.pywas causing attempts to use trollflow2 with dask distributed to fail with a RuntimeError.flake8 trollflow2I don't know how to add a unit test for this.