Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging to handler config without loggers #199

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Feb 12, 2024

This PR allows trollflow2 to accept log configs without loggers.

@mraspaud mraspaud added the bug Something isn't working label Feb 12, 2024
@mraspaud mraspaud self-assigned this Feb 12, 2024
@mraspaud mraspaud requested a review from pnuu as a code owner February 12, 2024 17:21
pnuu
pnuu previously approved these changes Feb 12, 2024
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0713a86) 95.76% compared to head (3bed599) 95.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   95.76%   95.80%   +0.03%     
==========================================
  Files          13       13              
  Lines        2972     3000      +28     
==========================================
+ Hits         2846     2874      +28     
  Misses        126      126              
Flag Coverage Δ
unittests 95.80% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mraspaud mraspaud requested a review from pnuu February 13, 2024 07:57
@mraspaud mraspaud enabled auto-merge February 13, 2024 08:00
@mraspaud mraspaud disabled auto-merge February 29, 2024 08:27
@mraspaud mraspaud merged commit aaf85a9 into pytroll:main Feb 29, 2024
9 checks passed
@mraspaud mraspaud deleted the fix-logging branch February 29, 2024 08:28
@mraspaud mraspaud mentioned this pull request Feb 29, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants