Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reader for CAMEL emissivity datasets. #3023

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

simonrp84
Copy link
Member

@simonrp84 simonrp84 commented Dec 28, 2024

This PR adds a reader for the NASA / USGS CAMEL emissivity product, which is a Level 3 global, gridded, dataset of IR emissivity values at 13 spectral tie points.

As well as the emissivity data, this reader also supports the ancillary datasets (ndvi, quality flags, etc).

  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.09%. Comparing base (5984c29) to head (d1affa6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3023      +/-   ##
==========================================
- Coverage   96.10%   96.09%   -0.01%     
==========================================
  Files         377      379       +2     
  Lines       55163    55277     +114     
==========================================
+ Hits        53012    53118     +106     
- Misses       2151     2159       +8     
Flag Coverage Δ
behaviourtests 3.93% <0.00%> (-0.01%) ⬇️
unittests 96.18% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Dec 28, 2024

Pull Request Test Coverage Report for Build 12544590386

Details

  • 115 of 115 (100.0%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.006%) to 96.2%

Files with Coverage Reduction New Missed Lines %
satpy/tests/utils.py 2 93.16%
satpy/tests/reader_tests/gms/test_gms5_vissr_l1b.py 3 98.67%
satpy/tests/reader_tests/gms/test_gms5_vissr_navigation.py 3 97.18%
Totals Coverage Status
Change from base Build 12299617024: -0.006%
Covered Lines: 53363
Relevant Lines: 55471

💛 - Coveralls

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments inline.

satpy/readers/camel_l3_nc.py Show resolved Hide resolved
satpy/readers/camel_l3_nc.py Outdated Show resolved Hide resolved
satpy/readers/camel_l3_nc.py Outdated Show resolved Hide resolved
@simonrp84
Copy link
Member Author

Thanks @pnuu! I've committed some changes that should address your comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants