Linux Wheel builds for Manylinux1. Use alternative to actions, checkout, upload #5941
Conversation
|
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
atalman
changed the title
atalman
changed the title
test test test test test test test test fix test test test test test test test test test test test test test test test test test test test test test test test test test test test fix test
atalman
force-pushed
the
modify_linux_wheels
branch
from
dad5e05
to
4e360ab
Compare
| @@ -185,10 +194,12 @@ jobs: | |||
| repository: ${{ inputs.repository }} | |||
| ref: ${{ inputs.ref }} | |||
| submodules: ${{ inputs.submodules }} | |||
| setup-miniconda: ${{ inputs.setup-miniconda }} | |||
| setup-miniconda: false | |||
There was a problem hiding this comment.
This is not really required miniconda is already installed on these images now. However may need to use Install Miniforge step here for Linux as well in future
atalman
changed the title
atalman
changed the title
|
Test Workflow with Vision: https://github.com/pytorch/test-infra/actions/runs/11939993337/job/33281723865?pr=5949 |
| with: | ||
| repository: ${{ inputs.repository }} | ||
| ref: ${{ inputs.ref }} | ||
| submodules: ${{ inputs.submodules }} | ||
| path: ${{ inputs.repository }} | ||
|
|
||
| - uses: atalman/checkout-action@main |
There was a problem hiding this comment.
Lets keep both actions/checkout@v4 and atalman/checkout-action@main. I believe this action is run on Windows and MacOS. I see no reason to debug this on these OS's
|
Please note moving https://github.com/atalman/checkout-action to script can be posted as BE followup PR. Advantage of the action is that it supports multiple Linux flavors: https://github.com/atalman/checkout-action/blob/main/main.sh#L81 . I am seeing this as temporary change to get us thru migration and 2.6/2.6.1 release |
This skip usage of for Manylinux1 images:
actions/checkout@v4actions/download-artifact@v3actions/upload-artifact@v3Uses https://github.com/atalman/checkout-action which does not use nodejs to checkout.
This does not require full rewrite of the Build Linux Wheels at this point and will allow us to use Build Linux Wheels for both Manylinx 2.28 and Manylinx1 images. This should not disrupt any of the existing Domains, since workflow will be exactly the same. Basically instead of complete rewrite, we rewrite only part that failing in Github actions.
Test Workflow: https://github.com/pytorch/test-infra/actions/runs/11937438064/job/33273483586?pr=5941
Please note Linux jobs are using Manylinux2_28 while Rocm are using Manylinux1
This should also fix the SEV, since it bring back the support for both platforms: pytorch/pytorch#140631