[FA] add persistent variant #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
manman-ren
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
manman-ren
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
|
@manman-ren has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Can you take a look at the CI failure? If the kernel does not work on the Triton versions we test (pytorch and Triton-main), we need to add them to the skip list: https://github.com/pytorch-labs/tritonbench/tree/main/test/test_gpu |
manman-ren
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
manman-ren
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
manman-ren
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
manman-ren
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
manman-ren
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
manman-ren
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
manman-ren
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
manman-ren
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
htyu
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
htyu
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
manman-ren
force-pushed
the
fa-persistent
branch
from
ba794c5 to
de3628b
Compare
manman-ren
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
manman-ren
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
manman-ren
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
manman-ren
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
manman-ren
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
manman-ren
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
htyu
approved these changes
Dec 2, 2024
xuzhao9
approved these changes
Dec 2, 2024
|
@manman-ren has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@manman-ren merged this pull request in 0a82d3d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hongtao identified the performance issue with the initial implementation and updated the assignments of tiles to each SM.
Performance with warp specialization
(Batch, Heads, SeqLen, Dhead) triton_tutorial_flash_v2_tma_ws_persistent-tflops triton_tutorial_flash_v2_tma_ws-tflops triton_tutorial_flash_v2-tflops