Enable bwd for flash_attention #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
xuzhao9
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
can you please share a screenshot of the output or confirm it ran as expected? |
|
@adamomainz Sorry it is not ready yet and I am still debugging - I will request review again when it is ready |
|
@xuzhao9 no problem at all happy to review again once ready! |
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xuzhao9
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
xuzhao9
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
adamomainz
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some backends (e.g., flash_attention/xformers_splitk) don't have backward pass. For those backends, add
fwd_only=Trueflag, and we will skip the backward pass automatically.If user specifies
--only xformers_splitk --bwd, we will still run the backend since it is user-specified. Otherwise we will always skip this backend.Test plan: