Use code detection to check bwd method override. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xuzhao9
force-pushed
the
xz9/detect-bwd
branch
from
e5282f4 to
4b7f1b0
Compare
xuzhao9
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
adamomainz
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use a smarter way to detect whether an operator has implemented backward. This can help speedup the unit test.