Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support flops metric in proton profiling #111

Closed
wants to merge 1 commit into from
Closed

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Dec 11, 2024

Summary:
Support tflops+proton metric on more operators.

Now we require operator to use def flops(): and the framework will add tflops metric automatically.
The same interface will be used to support flops in Proton.

Differential Revision: D67062546

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67062546

xuzhao9 added a commit that referenced this pull request Dec 11, 2024
Summary:

Support tflops+proton metric on more operators.

Now we require operator to use `def flops(): ` and the framework will add `tflops` metric automatically.
The same interface will be used to support `flops` in Proton.

Differential Revision: D67062546
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67062546

@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload December 11, 2024 15:22 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload December 11, 2024 15:22 — with GitHub Actions Inactive
xuzhao9 added a commit that referenced this pull request Dec 11, 2024
Summary:

Support tflops+proton metric on more operators.

Now we require operator to use `def flops(): ` and the framework will add `tflops` metric automatically.
The same interface will be used to support `flops` in Proton.

Differential Revision: D67062546
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67062546

@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload December 11, 2024 15:37 — with GitHub Actions Inactive
xuzhao9 added a commit that referenced this pull request Dec 11, 2024
Summary:

Support tflops+proton metric on more operators.

Now we require operator to use `def flops(): ` and the framework will add `tflops` metric automatically.
The same interface will be used to support `flops` in Proton.

Differential Revision: D67062546
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67062546

Summary:

Support tflops+proton metric on more operators.

Now we require operator to use `def flops(): ` and the framework will add `tflops` metric automatically.
The same interface will be used to support `flops` in Proton.

Differential Revision: D67062546
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67062546

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67062546

Copy link
Member

@FindHao FindHao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 794bc77.

@xuzhao9 xuzhao9 deleted the export-D67062546 branch December 13, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants