Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics] Enable cudagraph mode for kineto_trace #106

Closed
wants to merge 7 commits into from

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Dec 7, 2024

  • Remove use_cuda_graph = False as we are now using non cudagraph as default. Many operators do not support cudagraph mode.
  • Enable --cudagraph --metrics kineto_trace to turn on cuda graph mode for Kineto trace.

@xuzhao9 xuzhao9 changed the title [docs] Example analysis on kineto trace metric [metrics] Enable cudagraph mode for kineto_trace Dec 7, 2024
@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Member

@FindHao FindHao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the updates!

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in 1fb46a3.

@xuzhao9 xuzhao9 deleted the xz9/kineto_analysis branch December 9, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants