Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics] Add proton profiling #102

Closed
wants to merge 8 commits into from
Closed

[metrics] Add proton profiling #102

wants to merge 8 commits into from

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Dec 6, 2024

Add Proton profiler support. The profiler will instrument into the run() function to instrument the benchmark process.

Test plan:

$ python run.py --op softmax --num-inputs 3 --metrics proton
Entering scope x_val_[4096, 256]
Exiting scope x_val_[4096, 256]
Entering scope x_val_[4096, 384]
Exiting scope x_val_[4096, 384]
Entering scope x_val_[4096, 512]
Exiting scope x_val_[4096, 512]
      x_val    naive_softmax-proton    triton_softmax-proton
-----------  ----------------------  -----------------------
[4096, 256]
[4096, 384]
[4096, 512]
$ proton-viewer  proton.hatchet -m time
image

@xuzhao9 xuzhao9 requested a review from fywkevin December 7, 2024 00:04
@xuzhao9 xuzhao9 marked this pull request as draft December 7, 2024 00:29
@xuzhao9 xuzhao9 changed the title [metrics] Add proton profiler WIP [metrics] Add proton profiler Dec 7, 2024
@xuzhao9 xuzhao9 changed the title WIP [metrics] Add proton profiler WIP [metrics] Add proton profiling Dec 7, 2024
@xuzhao9 xuzhao9 changed the title WIP [metrics] Add proton profiling [metrics] Add proton profiling Dec 7, 2024
@xuzhao9 xuzhao9 marked this pull request as ready for review December 7, 2024 00:46
@xuzhao9 xuzhao9 requested a review from adamomainz December 7, 2024 00:46
@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@adamomainz adamomainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Great job getting this working

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in 87dffcc.

@xuzhao9 xuzhao9 deleted the xz9/add-proton branch December 7, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants