Skip to content

Commit

Permalink
fixing small bug caused in gemms and softmax
Browse files Browse the repository at this point in the history
Summary:
gemms are failing because of logical bug here

flash_attention does not use this function and directly calls the downstream function. When testing the change for shuffled data I only tested on flash attention and didnt see this break in testing.

Reviewed By: danzimm

Differential Revision: D66706511

fbshipit-source-id: f89a7561a41d82b8c486bd6af097057b2413b7d2
  • Loading branch information
adamomainz authored and facebook-github-bot committed Dec 3, 2024
1 parent 0a82d3d commit ce74f5e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tritonbench/utils/data_utils.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
from .triton_op import IS_FBCODE


def get_production_shapes(op_name, op_type):
def get_production_shapes(op_name, op_type, shuffle_shapes=False):
"""Gets a list of Softmax shapes for benchmarking"""
if IS_FBCODE:
from .fb.durin_data import productionDataLoader

return [
shape
for shape in productionDataLoader.get_shapes_from_frozen_durin(
op_name, op_type
op_name, op_type, shuffle_shapes
)
]

0 comments on commit ce74f5e

Please sign in to comment.