Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-125560: Pin JIT CI to ubuntu-22.04 #125564

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Conversation

savannahostrowski
Copy link
Member

@savannahostrowski savannahostrowski commented Oct 16, 2024

Ideally, we'd pin to 24.04 but that seems to be broken right now. We can probably bump the version once some rough edges get ironed out in a couple weeks?

I did a little test run here https://github.com/savannahostrowski/cpython/actions/runs/11357983419/job/31591954044?pr=5 and everything looked good except x86_64-pc-windows-msvc (unrelated for obvious reasons and being handled in #125217)

(GitHub's general guidance is to use ubuntu-latest, so if folks feel strongly against this, this could also be a temporary measure until the issue resolves.)

@hugovk hugovk added the infra CI, GitHub Actions, buildbots, Dependabot, etc. label Oct 22, 2024
@hugovk
Copy link
Member

hugovk commented Nov 1, 2024

@savannahostrowski Are there still failures with 24.04? If so, let's merge and revisit upgrading later.

@Eclips4
Copy link
Member

Eclips4 commented Nov 1, 2024

FYI, test_embed failure is a known thing, see #126255 for more information

@hugovk
Copy link
Member

hugovk commented Nov 1, 2024

Looks like we still have stuff to figure out with #126255 etc., but let's merge just to pin to something, especially if ubuntu-latest is mid-rollout from 22.04 -> 24.04, and see also actions/runner-images#10636 (comment).

Let's merge, we can change to 24.04 later when we're ready.

@hugovk hugovk merged commit c84a136 into python:main Nov 1, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build infra CI, GitHub Actions, buildbots, Dependabot, etc. skip news topic-JIT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants