Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop failing CI upon codecov error 503 #3173

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Stop failing CI upon codecov error 503 #3173

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d1d54c
Stop failing CI upon codecov error 503
A5rocks Dec 25, 2024
8e2bfa9
Explicitly state that disabling CI failures is temporary
A5rocks Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,7 @@ jobs:
# multiple flags is marked as an error in codecov UI, but is actually fine
# https://github.com/codecov/feedback/issues/567
flags: Windows,${{ matrix.python }}
# this option cannot be set in .codecov.yml
fail_ci_if_error: true
fail_ci_if_error: false # change to true when using codecov action v5

Ubuntu:
name: 'Ubuntu (${{ matrix.python }}${{ matrix.extra_name }})'
Expand Down Expand Up @@ -288,7 +287,7 @@ jobs:
directory: empty
name: Ubuntu (${{ matrix.python }}${{ matrix.extra_name }})
flags: Ubuntu,${{ matrix.python }}
fail_ci_if_error: true
fail_ci_if_error: false

macOS:
name: 'macOS (${{ matrix.python }})'
Expand Down Expand Up @@ -330,7 +329,7 @@ jobs:
directory: empty
name: macOS (${{ matrix.python }})
flags: macOS,${{ matrix.python }}
fail_ci_if_error: true
fail_ci_if_error: false

# run CI on a musl linux
Alpine:
Expand Down Expand Up @@ -366,7 +365,7 @@ jobs:
directory: empty
name: Alpine
flags: Alpine,${{ steps.get-version.outputs.version }}
fail_ci_if_error: true
fail_ci_if_error: false

Cython:
name: "Cython"
Expand Down Expand Up @@ -426,7 +425,7 @@ jobs:
with:
name: Cython
flags: Cython,${{ steps.get-version.outputs.version }}
fail_ci_if_error: true
fail_ci_if_error: false

# https://github.com/marketplace/actions/alls-green#why
check: # This job does nothing and is only used for the branch protection
Expand Down
Loading