Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow additional redis args #445

Closed

Conversation

aquamatthias
Copy link

Hi,

we use arq in https://github.com/someengineering/fixbackend - thanks for a great library.
We are missing an option to provide redis settings unavailable in arq RedisSettings.
One example would be: health_check_interval.

This PR would allow the arguments to be passed when the pool is created.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Merging #445 (cab6f1e) into main (94cd878) will increase coverage by 0.19%.
Report is 10 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   96.27%   96.47%   +0.19%     
==========================================
  Files          11       11              
  Lines        1074     1078       +4     
  Branches      209      190      -19     
==========================================
+ Hits         1034     1040       +6     
  Misses         19       19              
+ Partials       21       19       -2     
Files Coverage Δ
arq/connections.py 89.93% <ø> (-0.13%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d7944b...cab6f1e. Read the comment docs.

@aquamatthias aquamatthias deleted the mv/additional_redis_args branch June 26, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant