Allow max_connections
to be set in RedisSettings
#406
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default settings for
Redis
is an "unbounded" (i.e.2**31
) connection pool.This means that misuse of the client can lead to the consumption of every available connection in Redis locking out additional clients and there is no way in
arq
to modify that setting without monkey patching or rolling your owncreate_pool
function. This PR exposes a setting for connection pool size.Allowing setting
max_connections
allows for a safeguard to preemptively thwart workers that are running amuck with client creation.