-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider KeyboardInterrupt/SystemExit at collection time #12191
Conversation
anitahammer
commented
Apr 6, 2024
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anitahammer indeed this is a much better UX.
Could you please also:
- Add a test for this to ensure we do not regress in the future. Probably a simple way to simulate this is to make a module raise
KeyboardInterrupt
during import and check that the session was interrupted and the message!!! KeyboardInterrupt !!!!!!!!!
showed up. - Add a CHANGELOG entry
- Add yourself to
AUTHORS
(optional)
Thank you for the feedback @nicoddemus ! I've added a test case and verified that it was failing before my changes. |
Hi @nicoddemus |
Thanks @anitahammer for the ping! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @anitahammer!