Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Instrument: LASP MgII #108

Merged
merged 15 commits into from
Dec 6, 2022
Merged

New Instrument: LASP MgII #108

merged 15 commits into from
Dec 6, 2022

Conversation

aburrell
Copy link
Member

@aburrell aburrell commented Dec 2, 2022

Description

Addresses pysat/pysatModels#124 by adding the LASP MgII data sets. Other Instruments in this issue should be moved to pysatModels.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

import datetime as dt
import pysat
import pysatSpaceWeather as py_sw

stime = dt.datetime(1981, 11, 6)
mgii = pysat.Instrument(inst_module=py_sw.instruments.sw_mgii, tag='composite')
mgii.download(date=stime)
mgii.load(date=stime)
print(mgii.data)

Yields:

                     mg_index
1981-11-06 12:00:00   0.28537

Test Configuration

  • Operating system: OS X Big Sur
  • Version number: Python 3.8
  • Any details about your local setup that are relevant: develop branch of pysat

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

Added general functions to support LISIRD downloads and data sets.
Use the new LISIRD functions in the F10.7 instrument.
Added an instrument for the LASP MgII core-to-wing ratio index.
Updated the documentation API.
Updated the changelog with a description of this pull request.
Changed a UserWarning to a logger warning.
@aburrell aburrell added this to the 0.0.9 milestone Dec 2, 2022
Made the imports alphabetical and imported only one module per line.
Updated the import order in the F10.7 Instrument module.
Fixed the logger warning format by using the non-deprecated call and not including bad input args.
@aburrell aburrell requested a review from jklenzing December 2, 2022 19:00
@aburrell aburrell added the enhancement New feature or request label Dec 2, 2022
Update the deprecated logger call 'warn' to 'warning'.
Added unit tests for accessible, uncovered lines in the LISIRD functions.
aburrell and others added 4 commits December 2, 2022 17:34
Update the F10.7 frequency definition to use DateOffset correctly.
Removed whitespace and unused imports.
This is the order the flake8 CI wants.
Fixed the time adjustment to use the correct kwarg.
@aburrell aburrell merged commit 408e355 into develop Dec 6, 2022
@aburrell aburrell deleted the lasp_mgii branch December 6, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Add more solar irradiance proxies
2 participants