Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGL: Update controlled information review statement for clarity #251

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

rstoneback
Copy link
Collaborator

Description

Addresses #(issue)

Update controlled information statement for clarity and to ensure pysat's legal rights are maintained.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Updated comments. No need for additional testing.

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

@rstoneback
Copy link
Collaborator Author

rstoneback commented Dec 20, 2024

So the doc error about the admonition wasn't causing the documentation tests to fail but it was incorrect as written. That is fixed. Still trying to sort out what the inline_table_error thing on Read the Docs is all about. This error is coming up in documentation I didn't modify.

@rstoneback
Copy link
Collaborator Author

extras_require issue now tracked in report #252

@rstoneback rstoneback requested a review from aburrell December 20, 2024 15:38
@rstoneback
Copy link
Collaborator Author

rstoneback commented Dec 20, 2024

Friendly heads up to @jklenzing given historical work but recognizing NASA has stopped support, plus government may be shutting down.

@rstoneback
Copy link
Collaborator Author

NASA websites are down causing the current documentation check errors. The previous errors are indeed fixed by my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant