Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Revert integration to GitHub service for coveralls on MacOS #237

Merged
merged 12 commits into from
Aug 5, 2024

Conversation

Aadarsh-Govada
Copy link
Collaborator

Description

Addresses #232

Coveralls was not producing a report for MacOS using the coverallsapp integration. The coveralls integration has been switched to the GitHub service in the case of MacOS runs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • Operating system: GitHub Actions MacOS
  • Version number: Python 3.11 and Python 3.12

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release

@Aadarsh-Govada Aadarsh-Govada requested a review from jklenzing July 30, 2024 18:23
@jklenzing jklenzing mentioned this pull request Aug 1, 2024
11 tasks
@jklenzing jklenzing merged commit fbf4676 into rc_0_0_6 Aug 5, 2024
21 of 23 checks passed
@jklenzing jklenzing deleted the cover branch August 5, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants