-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: unzip support for download #209
Conversation
Needs a test for the new bits of code. The only routine that uses this is in pysatModels. Potentially we can create a test object with a few zipped files hosted here. |
Removed the gz support for now since the TIMED datasets have other problems. Can be expanded in the future. Moving forward without tests for the time being to support pysatModels. |
Documented need for tests and possible solutions as #213. |
Coverage change consistent with new lines of code. |
Description
Addresses #103
Adds support to unzip files after download for zip files. Users can now specify a 'zip_method' as part of the download tags, which will send the zipped file to a temporary directory and extract it to the archival location.
Current version supports 'zip' only, but could be expanded for other file types later.
Type of change
How Has This Been Tested?
Tested with pysatModels at pysat/pysatModels#132
Test Configuration:
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release