-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: REACH data #206
ENH: REACH data #206
Conversation
Still needs:
|
The acknowledgement string is more complicated than expected. Using standard copy paste for now, documented potential paths forward in #207. |
Note for testing:
yields
Assuming you have downloaded files, running
will then yield the full acknowledgement string. |
Co-authored-by: Angeline Burrell <[email protected]>
Ok, the data loads well, but the global file attributes in MetaHeader have problems. A benign example that I would let pass is Note: you can access the object using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix load routine so that all meta header attributes are accessible using standard attribute access method.
Description
Type of change
How Has This Been Tested?
Test Configuration:
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the release
checklist on the wiki: https://github.com/pysat/pysat/wiki/Checklist-for-Release