Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiegcm patch -- broken windows tests #119

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Tiegcm patch -- broken windows tests #119

merged 2 commits into from
Aug 11, 2022

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Aug 10, 2022

Description

Addresses #118 (partial)

Adds a skip for tests that are broken in a windows environment. This should get the unit tests working again, though we probably need a warning in the function for windows or better documentation if 0.2.0 is released before this is fixed.

Also adds a changelog suggestion for the main PR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

on github actions

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

@jklenzing jklenzing mentioned this pull request Aug 10, 2022
10 tasks
@jklenzing jklenzing changed the title Tiegcm patch Tiegcm patch -- broken windows tests Aug 10, 2022
@jklenzing jklenzing marked this pull request as ready for review August 10, 2022 19:10
@jklenzing jklenzing requested a review from rstoneback August 10, 2022 19:10
@jklenzing jklenzing merged commit a244f82 into tiegcm Aug 11, 2022
@jklenzing jklenzing deleted the tiegcm-patch branch August 11, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants