-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Instrument: LASP MgII #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added general functions to support LISIRD downloads and data sets.
Use the new LISIRD functions in the F10.7 instrument.
Added an instrument for the LASP MgII core-to-wing ratio index.
Updated the documentation API.
Updated the changelog with a description of this pull request.
Changed a UserWarning to a logger warning.
Made the imports alphabetical and imported only one module per line.
Updated the import order in the F10.7 Instrument module.
Fixed the logger warning format by using the non-deprecated call and not including bad input args.
Update the deprecated logger call 'warn' to 'warning'.
Added unit tests for accessible, uncovered lines in the LISIRD functions.
aburrell
commented
Dec 2, 2022
Update the F10.7 frequency definition to use DateOffset correctly.
Removed whitespace and unused imports.
This is the order the flake8 CI wants.
Fixed the time adjustment to use the correct kwarg.
jklenzing
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses pysat/pysatModels#124 by adding the LASP MgII data sets. Other Instruments in this issue should be moved to pysatModels.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Yields:
Test Configuration
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release