Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Update pysat_rc.yml #16

Merged
merged 2 commits into from
Dec 5, 2023
Merged

BUG: Update pysat_rc.yml #16

merged 2 commits into from
Dec 5, 2023

Conversation

aburrell
Copy link
Member

@aburrell aburrell commented Dec 1, 2023

Description

Remove unneeded if statement for installation of dependencies. This bug was found in pysatSpaceWeather.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran on pysatSpaceWeather.

Test Configuration

  • Operating system: GitHub Action
  • Version number: Python 3.11
  • Any details about your local setup that are relevant

Checklist:

  • [N/A] Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have linted the files updated in this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

Remove unneeded if statement for installation of dependencies.
@aburrell aburrell requested a review from jklenzing December 1, 2023 23:42
Updated coveralls call in the pysat RC CI yaml template.
@aburrell aburrell merged commit ac864d4 into main Dec 5, 2023
@aburrell aburrell deleted the aburrell-patch-1 branch December 5, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants